Add a benchmark that focuses on Paint object performance #60939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
c: contributor-productivity
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
yjbanov
force-pushed
the
bench-variable-paint
branch
from
8edff67 to
906472d
Compare
harryterkelsen
approved these changes
Jul 9, 2020
| /// | ||
| /// This is used to benchmark the efficiency of passing a large number of | ||
| /// paint objects to the rendering system. | ||
| final bool isVariablePaint; |
There was a problem hiding this comment.
nit: maybe rename to something clearer like useUniquePaint?
There was a problem hiding this comment.
Done (renamed to benchmarkPaint as discussed offline)
|
Merging on red iOS bot. It seems to have failed with the same timeout error as when it succeeded with a flake, so I'm suspecting flakiness. This code is unrelated to iOS anyway. |
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
* Add a benchmark the focuses on Paint object performance
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a benchmark that focuses on
Paintobject performance. This benchmark is more sensitive to@JSmigration than the existing one.