Skip to content

Random unresolved doc reference fixes I missed before #62582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2020
Merged

Random unresolved doc reference fixes I missed before #62582

merged 2 commits into from
Jul 30, 2020

Conversation

goderbauer
Copy link
Member

@fluttergithubbot fluttergithubbot added a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jul 30, 2020
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@goderbauer goderbauer changed the title Random unresolved doc reference fixs I missed before Random unresolved doc reference fixes I missed before Jul 30, 2020
@goderbauer goderbauer requested a review from gspencergoog July 30, 2020 16:12
gspencergoog
gspencergoog reviewed Jul 30, 2020
View reviewed changes
packages/flutter_driver/lib/src/extension/extension.dart Outdated
@@ -33,6 +33,8 @@ import '../common/wait.dart';
import '_extension_io.dart' if (dart.library.html) '_extension_web.dart';
import 'wait_conditions.dart';

export 'wait_conditions.dart';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed for the docs fixes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the docs reference stuff from there, it wasn't part of the public API though and no docs were generated for it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, we could change the docs to not reference this. Let me check that this should actually be part of the public API...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, just exporting this for the docs is strange since it isn't really part of the public API. I instead changed the location where it was referenced to not link it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

gspencergoog
gspencergoog approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@fluttergithubbot fluttergithubbot merged commit 3955101 into flutter:master Jul 30, 2020
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
@goderbauer @Pragya007
Random unresolved doc reference fixes I missed before (flutter#62582)
4e59568
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@goderbauer @mingwandroid
Random unresolved doc reference fixes I missed before (flutter#62582)
82cceda
@goderbauer goderbauer deleted the minorFixes branch November 11, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees
No one assigned
Labels
a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@goderbauer @fluttergithubbot @gspencergoog @googlebot