Skip to content

remove flaky flag for flutter_gallery_sksl_warmup__transition_perf_e2e #64770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Conversation

CareF
Copy link
Contributor

@CareF CareF commented Aug 28, 2020

Remove flaky flag as the android version is proven to be stable.

Issue with flutter_gallery_sksl_warmup__transition_perf_e2e_ios32 is tracked in #64771, similar to its driver version flutter_gallery_sksl_warmup_ios32__transition_perf, and should remain flagged.

@CareF CareF requested a review from liyuqian August 28, 2020 03:05
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 28, 2020
Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite hostonly_devicelab_tests-0-windows has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit 3579f1c into flutter:master Aug 28, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants