-
Notifications
You must be signed in to change notification settings - Fork 29.1k
Add missing margin to SnackBarAction #67167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Albert221 welcome! And thank you for the contribution. It looks like there is a merge conflict, can you update your change to resolve it?
It looks like the latest update included the NNBD migration of the test files you are working in, so your tests will need to be null safe. That should resolve the test failures here. |
Of course, here's the fixed version! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request is not suitable for automatic merging in its current state.
|
Description
Fixes #48042. Adds a horizontal margin to the SnackBar action, according to Material Design guidelines.
As you can see on the first screenshot below (before), the SnackBarAction does not have any space between the right button border and the right snackbar border which is not a correct appearance according to Material Design guidelines
Before
After
Related Issues
#48042
Tests
I added the following tests:
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.
Yes, I changed some of the existing tests, but they weren't following the spec in Material Design guidelines too. That change is really cosmetic, I don't think there is a need for a migration guide or a design doc.