Skip to content

Conversation

darrenaustin
Copy link
Contributor

Description

This was broken out of the larger #67790 to just handle migrating the Switch tests. This required making a change to the type of callback onChanged in the Switch widget. It is now ValueChanged<bool>? to match the value which can't be null for the switch.

Also changed the type of Switch's onChanged to a ValueChanged<bool>? to match it's value.
@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Oct 14, 2020
@google-cla google-cla bot added the cla: yes label Oct 14, 2020
@darrenaustin darrenaustin changed the title Migrate Switch tests top null safety. Migrate Switch tests to null safety. Oct 14, 2020
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 2c59a3a into flutter:master Oct 14, 2020
@darrenaustin darrenaustin deleted the nnbd_switch branch April 26, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants