Skip to content

Conversation

liyuqian
Copy link
Contributor

The test has been green for all the last 10 runs.

Meanwhile, remove the non-e2e version as it's still flaky so we can save
some device lab resources.

The test has been green for all the last 10 runs.

Meanwhile, remove the non-e2e version as it's still flaky so we can save
some device lab resources.
@liyuqian liyuqian requested a review from CareF October 19, 2020 19:05
@google-cla google-cla bot added the cla: yes label Oct 19, 2020
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Oct 19, 2020
Copy link
Contributor

@CareF CareF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 91a5a1e into flutter:master Oct 19, 2020
liyuqian added a commit to liyuqian/website that referenced this pull request Oct 21, 2020
The non-e2e test is deleted in flutter/flutter#68511
liyuqian added a commit to flutter/website that referenced this pull request Oct 21, 2020
@liyuqian liyuqian deleted the e2e_warmup branch November 13, 2020 20:42
filiph pushed a commit to filiph/website that referenced this pull request Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants