Skip to content

Add -miphoneos-version-min=8.0 to App framework stub #70405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2020
Merged

Add -miphoneos-version-min=8.0 to App framework stub #70405

merged 1 commit into from
Nov 12, 2020

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Nov 12, 2020

Description

Add -miphoneos-version-min=8.0 when building the stub framework.

Before this change:

Load command 8
       cmd LC_BUILD_VERSION
   cmdsize 32
  platform 7
       sdk 14.2
     minos 14.2
    ntools 1
      tool 3
   version 609.7

After this change:

Load command 8
      cmd LC_VERSION_MIN_IPHONEOS
  cmdsize 16
  version 8.0
      sdk 14.2

Related Issues

Fixes #52817

@jmagman jmagman added the platform-ios iOS applications specifically label Nov 12, 2020
@jmagman jmagman self-assigned this Nov 12, 2020
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 12, 2020
@google-cla google-cla bot added the cla: yes label Nov 12, 2020
christopherfujino
christopherfujino approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman mentioned this pull request Nov 12, 2020
Closed
@jmagman
Copy link
Member Author

jmagman commented Nov 12, 2020

Thanks for pinpointing this issue and testing it, @BernardGatt!

Google test failures unrelated. Merging.

@jmagman jmagman merged commit d11859f into flutter:master Nov 12, 2020
@jmagman jmagman deleted the min-version branch November 12, 2020 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees

@jmagman jmagman

Labels
platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App.framework/App: mach-o, but not built for iOS simulator
2 participants
@jmagman @christopherfujino