Skip to content

Conversation

xu-baolin
Copy link
Member

@xu-baolin xu-baolin commented Jan 8, 2021

As title.
If the bottomsheet takes all horizontal space (most do), the snackbar is invisible to the user.
image

Fixes #63254
Close #19547

Test coming soon.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jan 8, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Jan 8, 2021
@xu-baolin
Copy link
Member Author

@Piinks Hi,
Do you have any suggestions about the test case? Can I only use the Goden test for this issue?

@Piinks
Copy link
Contributor

Piinks commented Jan 8, 2021

@Piinks Hi,
Do you have any suggestions about the test case? Can I only use the Goden test for this issue?

A golden file test SGTM!

@skia-gold
Copy link

Gold has detected about 1 untriaged digest(s) on patchset 3.
View them at https://flutter-gold.skia.org/cl/github/73558

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #73558 at sha fa3f901

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Jan 9, 2021
@HansMuller HansMuller requested a review from Piinks January 14, 2021 19:06
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM
This is a great fix @xu-baolin thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files
Projects
None yet
4 participants