Skip to content

Use a null default skip value in testWidgets so it can inherit the group's skip flag #76174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2021
Merged

Use a null default skip value in testWidgets so it can inherit the group's skip flag #76174

merged 1 commit into from
Feb 17, 2021

Conversation

jason-simmons
Copy link
Member

Fixes #76135

@jason-simmons jason-simmons requested a review from Hixie February 17, 2021 01:48
@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Feb 17, 2021
@google-cla google-cla bot added the cla: yes label Feb 17, 2021
Hixie
Hixie approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc @goderbauer since I think we looked at this once before and there was some problem with this?

@Hixie
Copy link
Contributor

Hixie commented Feb 17, 2021

(of course personally I'd just get rid of group entirely, but...)

goderbauer
goderbauer approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 6757c7d into flutter:master Feb 17, 2021
daohoangson added a commit to daohoangson/flutter_glove_box that referenced this pull request Feb 22, 2021
@daohoangson
Use a null default skip value in testGoldens
9cb99be 
Use a null default skip value in testGoldens so it can inherit the group's skip flag.
Related to flutter/flutter#76174
@daohoangson daohoangson mentioned this pull request Feb 22, 2021
Closed
daohoangson added a commit to daohoangson/flutter_glove_box that referenced this pull request Mar 4, 2021
@daohoangson
Use a null default skip value in testGoldens
368c260 
Use a null default skip value in testGoldens so it can inherit the group's skip flag.
Related to flutter/flutter#76174
@daohoangson daohoangson mentioned this pull request Mar 4, 2021
Closed
@caseycrogers caseycrogers mentioned this pull request May 12, 2021
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hixie Hixie Hixie approved these changes

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests using testWidget() inside groups marked skip:true still run
4 participants
@jason-simmons @Hixie @goderbauer @fluttergithubbot