Removed InputDecorator accentColor dependency. #77999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrenaustin
added
framework
19 tasks
HansMuller
approved these changes
Mar 12, 2021
| testWidgets('InputDecoration default border uses colorScheme', (WidgetTester tester) async { | ||
| final ThemeData theme = ThemeData.from(colorScheme: const ColorScheme.light()); | ||
| final Color enabledColor = theme.colorScheme.onSurface.withOpacity(0.38); | ||
| final Color hoverColor = Color.alphaBlend(theme.hoverColor.withOpacity(0.12), enabledColor); |
|
This pull request is not suitable for automatic merging in its current state.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the InputDecorator widget's accentColor dependency per #56918.
The previous implementation used
ThemeData.accentColorandThemeData.primaryColorfor default border and label text colors. This PR changes them to the theme'scolorScheme.primaryinstead.Breaking change
This is a breaking change. For apps that need specific colors for these values, you can use the
InputDecoratorThemeto configure the exact colors needed.Added tests to verify the new default value for the border and label colors.
This PR was tested against internal Google apps in cl/359840215.