Inline some element methods for better stack overflow affinity #78269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73730.
Locally, this reduced the stack_size benchmark by 30% in release mode at the expense of slightly higher binary size. Example binary increase for the Gallery app on android-arm64:
libapp.so
(the Dart AOT) increased by 53.9 KB (+0.2%) uncompressedA local spot check with the gallery transition perf benchmark did not reveal any notable changes in build performance.
Last, but not least, this allows developers to nest more widget before facing a stack overflow. In a test setup, an additional ~900 containers could be nested before a stack overflow occurred.
See also #73730 for details on the points discussed above.