InteractiveViewer should call onInteractionUpdate even when gesture is disabled #78990
Conversation
flutter-dashboard
bot
added
the
framework
| @@ -781,6 +781,12 @@ class _InteractiveViewerState extends State<InteractiveViewer> with TickerProvid | |||
| // Handle an update to an ongoing gesture. All of pan, scale, and rotate are | |||
| // handled with GestureDetector's scale gesture. | |||
| void _onScaleUpdate(ScaleUpdateDetails details) { | |||
| widget.onInteractionUpdate?.call(ScaleUpdateDetails( | |||
There was a problem hiding this comment.
Is there a reason a new ScaleUpdateDetails has to be constructed instead of just passing details to the callback?
There was a problem hiding this comment.
The documentation states:
At the time this is called, the TransformationController will have already been updated to reflect the change caused by the interaction.
Is the statement still true?
There was a problem hiding this comment.
About ScaleUpdateDetails: The reason was that I didn't want to pass things that weren't being applied, like independent vertical and horizontal scales. However, given that I call this even when all interaction is disabled, I think you're right and I should just pass everything.
About the docs: You're right, thanks for catching that. I think I should actually keep the behavior as it is documented. I'll move my calls to onInteractionUpdate.
InteractiveViewer provides onInteractionStart/Update/End events so that users can get information about gestures happening on the child without running into problems with overlapping GestureDetectors. This information should be provided even when the gesture is disabled, and it is documented as such. However, onInteractionUpdate wasn't being called. This PR fixes it.
Closes #77455