Refactor text editing test APIs (Mark III) #80003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: tests
|
Internal Google test that failed with this has been migrated to use testWidgets to avoid the issue. |
|
@goderbauer may I bother you for a review? I believe this is unchanged (except for merges) since the last time you reviewed it. |
|
This pull request is not suitable for automatic merging in its current state.
|
|
This pull request is not suitable for automatic merging in its current state.
|
...and remove a legacy TODO whose referenced issue (flutter#51885) is now closed. To actually fix this required some refactoring of the text editing test APIs. See flutter#77454 and flutter#79061 for earlier discussions. This was last reverted in flutter#79559.
|
This got reverted again, I'll land it as part of #81235 once google3 is ready. |
angjieli
added a commit
that referenced
this pull request
Apr 27, 2021
Hixie
added a commit
to Hixie/flutter
that referenced
this pull request
May 1, 2021
Hixie
added a commit
to Hixie/flutter
that referenced
this pull request
May 14, 2021
* Moves the handlePlatformMessage logic to using ChannelBuffers. * Moves the testing APIs from services library to flutter_test. * Refactors text editing test APIs. * This is a reland of flutter#76288 and flutter#78637. See flutter#77454, flutter#79061, flutter#80003, flutter#81235, and flutter#82057 for earlier discussions. This was last reverted in flutter#82525.
Hixie
added a commit
to Hixie/flutter
that referenced
this pull request
May 21, 2021
* Moves the handlePlatformMessage logic to using ChannelBuffers. * Moves the testing APIs from services library to flutter_test. * Refactors text editing test APIs. * This is a reland of flutter#76288 and flutter#78637. See flutter#77454, flutter#79061, flutter#80003, flutter#81235, and flutter#82057 for earlier discussions. This was last reverted in flutter#82525.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and remove a legacy TODO whose referenced issue (#51885) is now closed.
To actually fix this required some refactoring of the text editing test APIs.
See #77454 and #79061 for earlier discussions. This was last reverted in #79959.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.