Revert "Fixes listview shrinkwrap and hidden semantics node gets upda… #88886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted incorrectly. (flutter#88814)" This reverts commit 0e9665e.
flutter-dashboard
bot
added
the
framework
|
FWIW, I think the internal screen diffs that "failed" because of this actually look more reasonable now, but I'm not 100% sure - we should talk to the owners about it. |
|
(reverting while we do that is of course a good idea :) |
|
I dont know what their ui looks like, some of them seems to render more items than the origin. I have to look into the customers' code to be sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
causes internal test failure
#84719
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.