Skip to content

Account for additional warning text from the tool #88902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Account for additional warning text from the tool #88902

merged 1 commit into from
Aug 25, 2021

Conversation

zanderso
Copy link
Member

The change to update the tool to use dart pub was reverted, and needs further investigation from @sigurdm.

In the meantime pub has started generating warning output directing users to migrate.

This PR updates the overall_experience_test to compensate for the additional output.

@zanderso zanderso requested review from cbracken and sigurdm August 25, 2021 20:34
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 25, 2021
@google-cla google-cla bot added the cla: yes label Aug 25, 2021
@zanderso
Copy link
Member Author

Customer tests have passed but cirrus is not reporting back properly. Landing manually to help unblock the Engine roll.

@zanderso zanderso merged commit cff3db1 into flutter:master Aug 25, 2021
@zanderso zanderso deleted the fix-overall-experience-test branch August 25, 2021 21:55
@sigurdm
Copy link
Contributor

sigurdm commented Aug 26, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants