Skip to content

Add raster cache metrics to timeline summaries #89393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

flar
Copy link
Contributor

@flar flar commented Sep 2, 2021

Recently some internal benchmarks have pointed out higher memory usage while using the DisplayList mechanism. In diagnosing the issue locally we realized we are using a lot more cache memory for internal benchmarks like the flutter_gallery. This PR will add statistics for layer and raster cache usage to the standard benchmark measurements we take for flutter_gallery which should alert us to issues in the future.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Sep 2, 2021
@google-cla google-cla bot added the cla: yes label Sep 2, 2021
@flar
Copy link
Contributor Author

flar commented Sep 2, 2021

The comment about the lack of testing is now obsolete as there are existing tests that I had to modify to get this to pass, so the additions are now tested for.

@flar flar force-pushed the add-raster-cache-metrics-to-timeline-summaries branch from 3976d77 to f97664b Compare September 4, 2021 01:47
@flar
Copy link
Contributor Author

flar commented Sep 4, 2021

The FrameTiming mods have rolled in from the engine repo and the latest commit now publishes those metrics as well for e2e benchmarks.

@flar flar requested a review from zanderso September 4, 2021 02:30
@fluttergithubbot fluttergithubbot merged commit abfb889 into flutter:master Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants