[flutter_tools] add working directory to ProcessException when pub get fails #91436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
jmagman
reviewed
Oct 7, 2021
| @@ -2,6 +2,8 @@ | |||
| // Use of this source code is governed by a BSD-style license that can be | |||
| // found in the LICENSE file. | |||
|
|
|||
| import 'dart:io' as io; | |||
There was a problem hiding this comment.
This is a forbidden import, you'll need to add this path to
Also, let's limit the package leak to just ProcessException.
Suggested change
| import 'dart:io' as io; | |
| import 'dart:io' as io show ProcessException; |
There was a problem hiding this comment.
actually, it's already in scope as io from line 14. I'm surprised this compiles...
zanderso
approved these changes
Oct 7, 2021
| throw io.ProcessException( | ||
| exception.executable, | ||
| exception.arguments, | ||
| '${exception.message}\nWorking directory: "$directory"', |
There was a problem hiding this comment.
Is there anything else that would be useful to put in here while you're at it? Anything from the environment or maybe the flutterRootOverride?
There was a problem hiding this comment.
it looks like flutterRootOverride is only ever set in tests.
There was a problem hiding this comment.
(i'm looking for relevant env vars)
There was a problem hiding this comment.
added what we're sending to pub as PUB_ENVIRONMENT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add debugging for #80418