Add devicelab benchmark tags support #92141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
c: contributor-productivity
keyonghan
changed the title
| /// "host_type": "linux", | ||
| /// "host_version": "debian-10.11" | ||
| /// } | ||
| List<MetricPoint> parse(Map<String, dynamic> resultsJson, Map<String, dynamic> benchmarkTags) { |
There was a problem hiding this comment.
Would benchmark tags be synonymous with the BuildBucket build's properties?
There was a problem hiding this comment.
They are similar in denoting useful test related info, but the benchmark tags here focus on benchmark related ones, especially the device and host info.
There was a problem hiding this comment.
How do we plan to generate these values? Is it a filtered set from the properties?
There was a problem hiding this comment.
It is not simply a subset of the properties, and the logic is not trivial.
I have a draft CL (WIP) to generate tags from recipes when running the tests.
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks! That's what I was curious about
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add benchmark tags support for devicelab benchmarks.
This will be a noop for existing workflow, unless we inject
tagsfrom recipe. A companion CL will be submitted soon.Related: #92203