Skip to content

Migrate integration test shard test data to null safety #92147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2021
Merged

Migrate integration test shard test data to null safety #92147

merged 1 commit into from
Oct 20, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Oct 20, 2021 •
edited
Loading

These files are only used in the integration tool test shard.

Part of #71511.

@jmagman jmagman added a: null-safety Support for Dart's null safety feature c: tech-debt Technical debt, code quality, testing, etc. labels Oct 20, 2021
@jmagman jmagman self-assigned this Oct 20, 2021
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 20, 2021
@google-cla google-cla bot added the cla: yes label Oct 20, 2021
@jmagman jmagman mentioned this pull request Oct 20, 2021
Closed
@jmagman jmagman marked this pull request as ready for review October 20, 2021 17:40
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor

Hixie commented Oct 20, 2021

test-exempt: is a test

christopherfujino
christopherfujino approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino
Copy link
Contributor

test-exempt: is a test

we (I guess I?) should update the bot to treat all files under a test or tests directory as test files.

@fluttergithubbot fluttergithubbot merged commit 305a855 into flutter:master Oct 20, 2021
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
@jmagman @clocksmith
Migrate integration test shard test data to null safety (flutter#92147)
46bfe7d
@jmagman jmagman deleted the test-data branch October 30, 2021 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees

@jmagman jmagman

Labels
a: null-safety Support for Dart's null safety feature c: tech-debt Technical debt, code quality, testing, etc. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmagman @Hixie @christopherfujino @fluttergithubbot