Skip to content

Add integration_test to flavor test project #92520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Oct 26, 2021

In anticipation for #89045, add integration_test to the flavors app.
Since it is the first plugin, handle the flavor build configurations in the Podfile.

Stop adding include? "Pods/Target Support Files/Pods-Runner/Pods-Runner.Debug.xcconfig" to the xcconfig if there's already a Pods include path in the file. Pods-Runner.Debug.xcconfig will not be correct when the target name is not Runner or when the build configuration (flavors) is not Debug.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@jmagman jmagman added platform-android Android applications specifically platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. t: xcode "xcodebuild" on iOS and general Xcode project management labels Oct 26, 2021
@jmagman jmagman self-assigned this Oct 26, 2021
@flutter-dashboard flutter-dashboard bot added f: integration_test The flutter/packages/integration_test plugin c: contributor-productivity Team-specific productivity, code health, technical debt. labels Oct 26, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Oct 26, 2021
@jmagman jmagman force-pushed the flavor-integration_test branch from 3bdb08a to 1d4772d Compare October 26, 2021 21:53
@jmagman jmagman force-pushed the flavor-integration_test branch from 1d4772d to 5fd13e0 Compare October 27, 2021 01:41
@jmagman jmagman requested review from blasten and cyanglaz October 27, 2021 17:35
@jmagman
Copy link
Member Author

jmagman commented Oct 27, 2021

+@blasten for the Android project change

Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit aff69e4 into flutter:master Oct 27, 2021
@jmagman jmagman deleted the flavor-integration_test branch October 27, 2021 19:54
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
WizzXu pushed a commit to WizzXu/flutter that referenced this pull request Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. f: integration_test The flutter/packages/integration_test plugin platform-android Android applications specifically platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants