-
Notifications
You must be signed in to change notification settings - Fork 29k
Add integration_test to flavor test project #92520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration_test to flavor test project #92520
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
3bdb08a
to
1d4772d
Compare
1d4772d
to
5fd13e0
Compare
+@blasten for the Android project change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In anticipation for #89045, add integration_test to the flavors app.
Since it is the first plugin, handle the flavor build configurations in the Podfile.
Stop adding
include? "Pods/Target Support Files/Pods-Runner/Pods-Runner.Debug.xcconfig"
to the xcconfig if there's already a Pods include path in the file.Pods-Runner.Debug.xcconfig
will not be correct when the target name is notRunner
or when the build configuration (flavors) is notDebug
.Pre-launch Checklist
///
).