-
Notifications
You must be signed in to change notification settings - Fork 29.1k
feat: migrate macos/macos_device.dart to null safety #92633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate macos/macos_device.dart to null safety #92633
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
@jmagman null safe mirgate pr |
@Hixie this pr need an test exemption |
4c20fe6
to
b82ccc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hixie this pr need an test exemption
Instead, please try to migrate the corresponding test, migrating tests at the same time can catch crashes. https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/general.shard/macos/macos_device_test.dart
c799bb3
to
96f3a13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
migrate macos/macos_device.dart to null safety
List which issues are fixed by this PR. You must list at least one issue.
#71511
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
NO
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.