Skip to content

Conversation

stuartmorgan-g
Copy link
Collaborator

Updates file_selector_android to Pigeon 26.x.

Fixes a latent bug in pigeons/file_selector_api.dart; it had a class that was marked as implements Exception; in older versions of Pigeon this was ignored, so was a no-op, but in current versions it triggers the very limited subclassing support, which doesn't allow inheriting from outside the interface definition, and thus generates incorrect code.

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Updates `file_selector_android` to Pigeon 26.x.

Fixes a latent bug in pigeons/file_selector_api.dart; it had a class
that was marked as `implements Exception`; in older versions of Pigeon
this was ignored, so was a no-op, but in current versions it triggers
the very limited subclassing support, which doesn't allow inheriting
from outside the interface definition, and thus generates incorrect
code.
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the file_selector_android package to use Pigeon version 26.x. The changes primarily consist of regenerating the platform communication code based on the updated dependency. A key fix is the removal of implements Exception from the FileSelectorNativeException class in the Pigeon definition file, which addresses a code generation issue in the new Pigeon version. The pubspec.yaml and CHANGELOG.md files have been updated accordingly. The changes are correct and well-contained, and I have no further feedback.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 29, 2025
@auto-submit auto-submit bot merged commit d29ad29 into flutter:main Sep 29, 2025
80 checks passed
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Sep 30, 2025
flutter/packages@34eec78...287739d

2025-09-29 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
d693b4b to ac4e799 (4 revisions) (flutter/packages#10124)
2025-09-29 magder@google.com Fix CODEOWNERS error
(flutter/packages#10127)
2025-09-29 stuartmorgan@google.com [file_selector] Update Pigeon in
Android implementation (flutter/packages#10126)
2025-09-29 31859944+LongCatIsLooong@users.noreply.github.com
[In_app_purchase_storekit] Do not throw PigeonError when a transaction
is pending / cancelled / unverified (flutter/packages#9627)
2025-09-29 stuartmorgan@google.com [video_player] Separate texture ID on
Android (flutter/packages#10029)
2025-09-29 engine-flutter-autoroll@skia.org Roll Flutter from
6cc976e to 96fe3b3 (32 revisions) (flutter/packages#10125)
2025-09-29 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Fix NV21 Format (flutter/packages#10022)
2025-09-29 engine-flutter-autoroll@skia.org Manual roll Flutter from
b1a28bc to 6cc976e (4 revisions) (flutter/packages#10116)
2025-09-29 robert.odrowaz@leancode.pl [camera_avfoundation]
Implementation swift migration - part 13 (flutter/packages#9930)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
okorohelijah pushed a commit to okorohelijah/flutter that referenced this pull request Oct 7, 2025
…r#176284)

flutter/packages@34eec78...287739d

2025-09-29 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
d693b4b to ac4e799 (4 revisions) (flutter/packages#10124)
2025-09-29 magder@google.com Fix CODEOWNERS error
(flutter/packages#10127)
2025-09-29 stuartmorgan@google.com [file_selector] Update Pigeon in
Android implementation (flutter/packages#10126)
2025-09-29 31859944+LongCatIsLooong@users.noreply.github.com
[In_app_purchase_storekit] Do not throw PigeonError when a transaction
is pending / cancelled / unverified (flutter/packages#9627)
2025-09-29 stuartmorgan@google.com [video_player] Separate texture ID on
Android (flutter/packages#10029)
2025-09-29 engine-flutter-autoroll@skia.org Roll Flutter from
6cc976e to 96fe3b3 (32 revisions) (flutter/packages#10125)
2025-09-29 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Fix NV21 Format (flutter/packages#10022)
2025-09-29 engine-flutter-autoroll@skia.org Manual roll Flutter from
b1a28bc to 6cc976e (4 revisions) (flutter/packages#10116)
2025-09-29 robert.odrowaz@leancode.pl [camera_avfoundation]
Implementation swift migration - part 13 (flutter/packages#9930)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: file_selector platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants