Skip to content

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Sep 29, 2025

Screenshot 2025-09-25 at 2 28 16 PM

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CODEOWNERS file to correct a username. The owner for packages/cross_file/** and packages/extension_google_sign_in_as_googleapis_auth/** has been changed from @stuartmorgan to @stuartmorgan-g. This change appears to fix an error with code ownership and aligns the entries with other packages in the file.

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I guess whoever changed those lines didn't realize I changed my username months ago 🤡

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 29, 2025
@auto-submit auto-submit bot merged commit 24c55df into main Sep 29, 2025
80 checks passed
@auto-submit auto-submit bot deleted the jmagman-patch-1 branch September 29, 2025 19:17
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 30, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Sep 30, 2025
flutter/packages@34eec78...287739d

2025-09-29 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
d693b4b to ac4e799 (4 revisions) (flutter/packages#10124)
2025-09-29 magder@google.com Fix CODEOWNERS error
(flutter/packages#10127)
2025-09-29 stuartmorgan@google.com [file_selector] Update Pigeon in
Android implementation (flutter/packages#10126)
2025-09-29 31859944+LongCatIsLooong@users.noreply.github.com
[In_app_purchase_storekit] Do not throw PigeonError when a transaction
is pending / cancelled / unverified (flutter/packages#9627)
2025-09-29 stuartmorgan@google.com [video_player] Separate texture ID on
Android (flutter/packages#10029)
2025-09-29 engine-flutter-autoroll@skia.org Roll Flutter from
6cc976e to 96fe3b3 (32 revisions) (flutter/packages#10125)
2025-09-29 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Fix NV21 Format (flutter/packages#10022)
2025-09-29 engine-flutter-autoroll@skia.org Manual roll Flutter from
b1a28bc to 6cc976e (4 revisions) (flutter/packages#10116)
2025-09-29 robert.odrowaz@leancode.pl [camera_avfoundation]
Implementation swift migration - part 13 (flutter/packages#9930)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
okorohelijah pushed a commit to okorohelijah/flutter that referenced this pull request Oct 7, 2025
…r#176284)

flutter/packages@34eec78...287739d

2025-09-29 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
d693b4b to ac4e799 (4 revisions) (flutter/packages#10124)
2025-09-29 magder@google.com Fix CODEOWNERS error
(flutter/packages#10127)
2025-09-29 stuartmorgan@google.com [file_selector] Update Pigeon in
Android implementation (flutter/packages#10126)
2025-09-29 31859944+LongCatIsLooong@users.noreply.github.com
[In_app_purchase_storekit] Do not throw PigeonError when a transaction
is pending / cancelled / unverified (flutter/packages#9627)
2025-09-29 stuartmorgan@google.com [video_player] Separate texture ID on
Android (flutter/packages#10029)
2025-09-29 engine-flutter-autoroll@skia.org Roll Flutter from
6cc976e to 96fe3b3 (32 revisions) (flutter/packages#10125)
2025-09-29 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Fix NV21 Format (flutter/packages#10022)
2025-09-29 engine-flutter-autoroll@skia.org Manual roll Flutter from
b1a28bc to 6cc976e (4 revisions) (flutter/packages#10116)
2025-09-29 robert.odrowaz@leancode.pl [camera_avfoundation]
Implementation swift migration - part 13 (flutter/packages#9930)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants