This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[firebase_analytics]Refactor unit test to use setMockMethodCallHandler
#1075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he change to minimum
amirh
reviewed
Jan 16, 2019
cyanglaz
changed the title
setMockMethodCallHandlersetMockMethodCallHandler
collinjackson
suggested changes
Jun 15, 2019
|
@collinjackson I made the change to use isMethodCall, but i'm sorry i not sure what to update pubspec.yaml/CHANGELOG. For observer_test.dart, I think it's good as is. |
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
…er` (flutter#1075) * resolve flutter#1075 (comment) with a more `dynamic` way while keep the change to minimum * resolve feedback flutter#1075 (comment)
collinjackson
pushed a commit
to firebase/flutterfire
that referenced
this pull request
Aug 14, 2019
…er` (#1075) * resolve flutter/plugins#1075 (comment) with a more `dynamic` way while keep the change to minimum * resolve feedback flutter/plugins#1075 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion on flutter/flutter#26456 (comment), I figured out we have several places in https://github.com/flutter/plugins using old hacking
.private, thus this is an continuingly attempt to clean up