This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Allow specifying a navigation delegate (iOS implementation). #1323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyanglaz
approved these changes
Mar 7, 2019
| } | ||
| NSDictionary* arguments = @{ | ||
| @"url" : navigationAction.request.URL.absoluteString, | ||
| @"isMainFrame" : [NSNumber numberWithBool:navigationAction.targetFrame.isMainFrame] |
There was a problem hiding this comment.
Just a suggestion, but the code looks fine. Feel free to not update this for this PR if you don't feel like to.
The [NSNumber numberWithBool..] can be short written as @(foo).
Suggested change
| @"isMainFrame" : [NSNumber numberWithBool:navigationAction.targetFrame.isMainFrame] | |
| @"isMainFrame" : @(navigationAction.targetFrame.isMainFrame) |
| arguments:arguments | ||
| result:^(id _Nullable result) { | ||
| NSNumber* typedResult = result; | ||
| decisionHandler([typedResult boolValue] ? WKNavigationActionPolicyAllow |
There was a problem hiding this comment.
Is there a possibility for the dart side code to fail and the result block not getting triggered?
There was a problem hiding this comment.
good catch, it shouldn't ever happen, but added some better logging in case it does.
amirh
added a commit
that referenced
this pull request
Mar 9, 2019
…art). (#1236) This allows the app to prevent specific navigations(e.g prevent navigating to specific URLs). flutter/flutter#25329 iOS implementation in #1323
jonasbark
pushed a commit
to jonasbark/plugins
that referenced
this pull request
Mar 11, 2019
* commit '9017d6e7f867af278edd7e8e584d52524f37443f': (408 commits) [webview_flutter]Allow specifying a navigation delegate(Android and Dart). (flutter#1236) Allow specifying a navigation delegate (iOS implementation). (flutter#1323) Change build link in contributors site to cirrus (flutter#1327) [image_picker] Update versioning for flutter#1268 (flutter#1326) [image_picker] remove unnecessary camera permmision (flutter#1268) Exclude longPress from semantics (flutter#1324) [in_app_purchase] refactoring and tests (flutter#1322) [in_app_purchase] Adds Dart BillingClient APIs for loading purchases (flutter#1286) [connectivity] Update README.md (flutter#1201) [camera] Fixes #28350 (flutter#1261) [cloud_functions] Specify version for CocoaPod and handle null regions gracefully (flutter#1316) [in_app_purchase]retrieve receipt (flutter#1303) [firebase_analytics] Add resetAnalyticsData method (flutter#1311) trackCameraPosition is inferred from GoogleMap.onCameraMove (flutter#1314) [google_maps_flutter]ChangeNotifier is replaced with granular callbacks (flutter#1302) [video_player]Do not divide by zero (flutter#793) [firebase_dynamic_links] Version bump for firebase_dynamic_links PR flutter#1142 (flutter#1309) [firebase_dynamic_links] fix dynamic link crash when creating shortlink if warnings are null (flutter#1142) Fix typo in RewardedVideoAdd sample (flutter#927) Add my name to firebase_performance and firebase_dynamic_links owners (flutter#1300) ... # Conflicts: # packages/camera/android/src/main/java/io/flutter/plugins/camera/CameraPlugin.java # packages/camera/ios/Classes/CameraPlugin.m # packages/firebase_auth/ios/Classes/FirebaseAuthPlugin.m # packages/image_picker/android/build.gradle # packages/video_player/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayerPlugin.java
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the iOS implementation of the navigation delegate method channel.
The Dart and Android implementations are in #1236
Splitting off the iOS to keep a reasonable change size.
This PR will be merged first.
flutter/flutter#25329