Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Exclude longPress from semantics #1324

Merged
merged 3 commits into from
Mar 8, 2019
Merged

Conversation

goderbauer
Copy link
Member

The longpress handler should not be exposed to the semantics tree since it doesn't do anything. It will just confuse screenreaders.

@goderbauer goderbauer requested a review from amirh March 7, 2019 22:42
Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can you add it to the change log and bump the version?

@goderbauer goderbauer merged commit 16b8678 into flutter:master Mar 8, 2019
jonasbark pushed a commit to jonasbark/plugins that referenced this pull request Mar 11, 2019
* commit '9017d6e7f867af278edd7e8e584d52524f37443f': (408 commits)
  [webview_flutter]Allow specifying a navigation delegate(Android and Dart). (flutter#1236)
  Allow specifying a navigation delegate (iOS implementation). (flutter#1323)
  Change build link in contributors site to cirrus (flutter#1327)
  [image_picker] Update versioning for flutter#1268 (flutter#1326)
  [image_picker] remove unnecessary camera permmision (flutter#1268)
  Exclude longPress from semantics (flutter#1324)
  [in_app_purchase] refactoring and tests (flutter#1322)
  [in_app_purchase] Adds Dart BillingClient APIs for loading purchases (flutter#1286)
  [connectivity] Update README.md (flutter#1201)
  [camera] Fixes #28350 (flutter#1261)
  [cloud_functions] Specify version for CocoaPod and handle null regions gracefully (flutter#1316)
  [in_app_purchase]retrieve receipt (flutter#1303)
  [firebase_analytics] Add resetAnalyticsData method (flutter#1311)
  trackCameraPosition is inferred from GoogleMap.onCameraMove (flutter#1314)
  [google_maps_flutter]ChangeNotifier is replaced with granular callbacks (flutter#1302)
  [video_player]Do not divide by zero (flutter#793)
  [firebase_dynamic_links] Version bump for firebase_dynamic_links PR flutter#1142 (flutter#1309)
  [firebase_dynamic_links] fix dynamic link crash when creating shortlink if warnings are null (flutter#1142)
  Fix typo in RewardedVideoAdd sample (flutter#927)
  Add my name to firebase_performance and firebase_dynamic_links owners (flutter#1300)
  ...

# Conflicts:
#	packages/camera/android/src/main/java/io/flutter/plugins/camera/CameraPlugin.java
#	packages/camera/ios/Classes/CameraPlugin.m
#	packages/firebase_auth/ios/Classes/FirebaseAuthPlugin.m
#	packages/image_picker/android/build.gradle
#	packages/video_player/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayerPlugin.java
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
* Move firebase_core to firebase_core/firebase_core
* Add firebase_core_platform_interface package
* Update cirrus scripts and documentation
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants