Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker] Fix invalid path being returned from Google Photos #1471

Merged
merged 2 commits into from
Apr 10, 2019
Merged

[image_picker] Fix invalid path being returned from Google Photos #1471

merged 2 commits into from
Apr 10, 2019

Conversation

yunyu
Copy link
Contributor

@yunyu yunyu commented Apr 9, 2019 •
edited by collinjackson
Loading

Description

Currently, getPathFromLocalUri returns a string purely consisting of integers when the user selects a photo from Google Photos through the sidebar entry. This fixes the issue by returning null, which causes getPathFromUri to fallback to getPathFromRemoteUri (which returns the correct path, see flutter/flutter#29667 (comment)).

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@yunyu yunyu requested a review from cyanglaz as a code owner April 9, 2019 16:40
@collinjackson
Copy link
Contributor

I would ideally like an integration test for this type of change; it would require getting our Android bots up and running and making sure they have Google Photos content. I don't think our testing needs should hold us back from merging a straightforward regression crash fix, so I'll go ahead and merge this.

@collinjackson collinjackson merged commit 9023ff2 into flutter:master Apr 10, 2019
thomas-stockx added a commit to thomas-stockx/plugins that referenced this pull request Apr 10, 2019
@thomas-stockx
Merge branch 'master' into feature/reset_packages
bd02c2e 
* master:
  [package_info] Integration tests. (flutter#1473)
  Integration tests for cloud_firestore and firebase_database transactions (flutter#1465)
  [image_picker] Fix invalid path being returned from Google Photos (flutter#1471)
  [firebase_messaging] Update example (flutter#1353)
  [Google_map]Enable iOS a11y by default. (flutter#1472)
  [shared_preferences] Add containsKey method (flutter#1373)

# Conflicts:
#	packages/package_info/CHANGELOG.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

Assignees
No one assigned
Labels
bugfix cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[image_picker] Pick image from Google Photos cause application crash
4 participants
@yunyu @collinjackson @googlebot @bparrishMines