Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[Google_map]Enable iOS a11y by default. #1472

Merged
merged 2 commits into from
Apr 9, 2019
Merged

[Google_map]Enable iOS a11y by default. #1472

merged 2 commits into from
Apr 9, 2019

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Apr 9, 2019 •
edited
Loading

Description

Enabling iOS a11y by default on Google Map. Google Map SDK disables the a11y by default (https://developers.google.com/maps/documentation/ios-sdk/map#accessibility). We will enable it for our plugins.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@cyanglaz cyanglaz requested a review from iskakaushik April 9, 2019 18:13
@cyanglaz cyanglaz requested a review from amirh as a code owner April 9, 2019 18:14
cbracken
cbracken approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

iskakaushik
iskakaushik approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iskakaushik iskakaushik merged commit 7fc9370 into flutter:master Apr 9, 2019
thomas-stockx added a commit to thomas-stockx/plugins that referenced this pull request Apr 10, 2019
@thomas-stockx
Merge branch 'master' into feature/reset_packages
bd02c2e 
* master:
  [package_info] Integration tests. (flutter#1473)
  Integration tests for cloud_firestore and firebase_database transactions (flutter#1465)
  [image_picker] Fix invalid path being returned from Google Photos (flutter#1471)
  [firebase_messaging] Update example (flutter#1353)
  [Google_map]Enable iOS a11y by default. (flutter#1472)
  [shared_preferences] Add containsKey method (flutter#1373)

# Conflicts:
#	packages/package_info/CHANGELOG.md
@cyanglaz cyanglaz deleted the google_map_a11y branch April 12, 2019 00:55
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
[firebase_core] Migrate to platform_interface (flutter#1472)
ad5ab7a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amirh amirh Awaiting requested review from amirh

2 more reviewers

@cbracken cbracken cbracken approved these changes

@iskakaushik iskakaushik iskakaushik approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cyanglaz @cbracken @iskakaushik @googlebot