This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] Support Flutter TextInputs
#1852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds logic to `InputAwareWebView#clearFocus` to reset input creation back to the container view's thread whenever the WebView is unfocused. Fixes issue where Flutter UIs could no longer receive InputConnections because WebView was causing all connections to happen on WebView's IME thread.
amirh
reviewed
Jul 15, 2019
| * longer has focus. | ||
| * | ||
| * <p>The logic in {@link #checkInputConnectionProxy} forces input creation to happen on Webview's | ||
| * thread for all connections. We undo it here so usres will be able to go back to typing in |
| new Runnable() { | ||
| @Override | ||
| public void run() { | ||
| containerView.onWindowFocusChanged(true); |
There was a problem hiding this comment.
What do you think about only do this if we've set the ThreadedInputConnectionProxyAdapterView as the input target?
amirh
reviewed
Jul 15, 2019
| new Runnable() { | ||
| @Override | ||
| public void run() { | ||
| containerView.onWindowFocusChanged(true); |
There was a problem hiding this comment.
[nit, can definitely happen in a different PR]
We're repeating this magic sequence in more than one place, this specific call site isn't document so someone stepping into this code will probably be confused. Would probably be useful to extract these steps to a common method.
There was a problem hiding this comment.
I'll clean it up in #1853.
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
[webview_flutter] Support Flutter `TextInput`s Adds logic to `InputAwareWebView#clearFocus` to reset input creation back to the container view's thread whenever the WebView is unfocused. Fixes issue where Flutter UIs could no longer receive InputConnections because WebView was causing all connections to happen on WebView's IME thread.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds logic to
InputAwareWebView#clearFocusto reset input creationback to the container view's thread whenever the WebView is unfocused.
Fixes issue where Flutter UIs could no longer receive InputConnections
because WebView was causing all connections to happen on WebView's IME
thread.
Manually tested using mklim/plugins@928c790.
Related Issues
flutter/flutter#19718
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?