This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] Fix input bug on route changes #1853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 15, 2019
added 2 commits
July 15, 2019 15:03
Fixes bug where the InputConnection proxy view was persisting across multiple WebView creation calls.
amirh
reviewed
Jul 15, 2019
|
|
||
| /** | ||
| * This is the crucial trick that gets the InputConnection creation to happen on the correct | ||
| * thread. |
| * <p>{@code targetView} should have a {@link View#getHandler} method with the thread that future | ||
| * InputConnections should be created on. | ||
| */ | ||
| private void setInputConnectionThread(final View targetView) { |
There was a problem hiding this comment.
nit: Maybe call it setInputConnectionTarget? (as the parameter is the target which also specified the thread, and not the thread itself.)
| } | ||
|
|
||
| /** | ||
| * Ensure that input creation happens back on {@link #containerView}'s thread. |
There was a problem hiding this comment.
Maybe: Ensure that input connection creation happens back on {@link #containerView}.
mklim
commented
Jul 15, 2019
| } | ||
|
|
||
| /** | ||
| * Ensure that input creation happens back on {@link #containerView}'s thread. |
|
|
||
| /** | ||
| * This is the crucial trick that gets the InputConnection creation to happen on the correct | ||
| * thread. |
| * <p>{@code targetView} should have a {@link View#getHandler} method with the thread that future | ||
| * InputConnections should be created on. | ||
| */ | ||
| private void setInputConnectionThread(final View targetView) { |
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
Fixes bug where the InputConnection proxy view was persisting across multiple WebView creation calls.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug where the InputConnection proxy view was persisting across
multiple WebView creation calls.
Manually tested with mklim/plugins@3e033be.
Related Issues
flutter/flutter#19718
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?