Skip to content

Fixup varfont_shader_puzzle, attempt #2 #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 13, 2023
Merged

Fixup varfont_shader_puzzle, attempt #2 #1563

merged 3 commits into from
Jan 13, 2023

Conversation

domesticmouse
Copy link
Contributor

Pre-launch Checklist

  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I read the Contributors Guide.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@domesticmouse domesticmouse mentioned this pull request Jan 13, 2023
Closed
5 tasks
parlough
parlough approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me after running the formatter :)

@domesticmouse domesticmouse merged commit 2c7ffd4 into flutter:main Jan 13, 2023
@domesticmouse domesticmouse deleted the Fixup-varfont_shader_puzzle branch January 13, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parlough parlough parlough approved these changes

@malloc-error malloc-error Awaiting requested review from malloc-error

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@domesticmouse @parlough