Skip to content

[compass_app] Don't expose Dimens subclasses #2541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2024
Merged

[compass_app] Don't expose Dimens subclasses #2541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions compass_app/app/lib/ui/core/themes/dimens.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import 'package:flutter/material.dart';

sealed class Dimens {
abstract final class Dimens {
const Dimens();

/// General horizontal padding used to separate UI items
Expand All @@ -14,10 +14,12 @@ sealed class Dimens {
static const paddingVertical = 24.0;

/// Horizontal padding for screen edges
abstract final double paddingScreenHorizontal;
double get paddingScreenHorizontal;

/// Vertical padding for screen edges
abstract final double paddingScreenVertical;
double get paddingScreenVertical;

double get profilePictureSize;

/// Horizontal symmetric padding for screen edges
EdgeInsets get edgeInsetsScreenHorizontal =>
Expand All @@ -27,39 +29,37 @@ sealed class Dimens {
EdgeInsets get edgeInsetsScreenSymmetric => EdgeInsets.symmetric(
horizontal: paddingScreenHorizontal, vertical: paddingScreenVertical);

static final dimensDesktop = DimensDesktop();
static final dimensMobile = DimensMobile();
static final Dimens desktop = _DimensDesktop();
static final Dimens mobile = _DimensMobile();

/// Get dimensions definition based on screen size
factory Dimens.of(BuildContext context) =>
switch (MediaQuery.sizeOf(context).width) {
> 600 => dimensDesktop,
_ => dimensMobile,
> 600 => desktop,
_ => mobile,
};

abstract final double profilePictureSize;
}

/// Mobile dimensions
class DimensMobile extends Dimens {
final class _DimensMobile extends Dimens {
@override
double paddingScreenHorizontal = Dimens.paddingHorizontal;
final double paddingScreenHorizontal = Dimens.paddingHorizontal;

@override
double paddingScreenVertical = Dimens.paddingVertical;
final double paddingScreenVertical = Dimens.paddingVertical;

@override
double get profilePictureSize => 64.0;
final double profilePictureSize = 64.0;
}

/// Desktop/Web dimensions
class DimensDesktop extends Dimens {
final class _DimensDesktop extends Dimens {
@override
double paddingScreenHorizontal = 100.0;
final double paddingScreenHorizontal = 100.0;

@override
double paddingScreenVertical = 64.0;
final double paddingScreenVertical = 64.0;

@override
double get profilePictureSize => 128.0;
final double profilePictureSize = 128.0;
}
2 changes: 1 addition & 1 deletion compass_app/app/lib/ui/results/widgets/results_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ class _AppSearchBar extends StatelessWidget {
child: Padding(
padding: EdgeInsets.only(
top: Dimens.of(context).paddingScreenVertical,
bottom: Dimens.dimensMobile.paddingScreenVertical,
bottom: Dimens.mobile.paddingScreenVertical,
),
child: AppSearchBar(
config: widget.viewModel.config,
Expand Down
Loading