[Gallery] Close Shrine cart on back button press for android #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perclasson
force-pushed
the
back_button_on_android_should_close_cart
branch
from
87ea3b1 to
5008aa2
Compare
perclasson
force-pushed
the
back_button_on_android_should_close_cart
branch
from
5008aa2 to
9747c6b
Compare
guidezpl
reviewed
Jan 28, 2020
guidezpl
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move up
WillPopScopeaboveMaterialAppto make sure that when the expanding bottom sheet (cart) is open, it will close the sheet instead of going back when pressing the back button on Android.Closes material-components/material-components-flutter-gallery#519