[Gallery] Fix slow motion setting announcement #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami-a
reviewed
Jan 31, 2020
gallery/gallery/lib/pages/home.dart
Outdated
| controller: _controller, | ||
| itemCount: widget.children.length, | ||
| itemBuilder: (context, index) => builder(index), | ||
| allowImplicitScrolling: true, |
There was a problem hiding this comment.
If i remember correctly, this flag was new and we couldn't use it yet because it wasn't in stable. Is this no longer the case?
There was a problem hiding this comment.
I wasn't sure, so I figured I'd let CI tell me
There was a problem hiding this comment.
Looks like it's in beta but not stable yet
There was a problem hiding this comment.
Ok, let's hold off on this until the next stable release then. Though feel free to do the other fix for slow motion
There was a problem hiding this comment.
cool, I'll repurpose this PR
guidezpl
requested review from
johnsonmh and
clocksmith
and removed request for
clocksmith and
johnsonmh
guidezpl
changed the title
This reverts commit cc8f233.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug with the slow motion setting a11y announcement