Skip to content

Conversation

guidezpl
Copy link
Member

@guidezpl guidezpl commented Feb 6, 2020

This PR implements the expected design for Crane's middle front layer being higher than the others. I opted not to create recreate custom version of existing Material widgets, instead using an OverflowBox. The only downside is there is a small portion of the middle tab that cannot be interacted with (see below in red). Since everything else remains functional, I think this is acceptable

Simulator Screen Shot - iPhone 11 Pro Max - 2020-02-06 at 10 22 53
Simulator Screen Shot - iPhone 11 Pro Max - 2020-02-06 at 10 22 58
Simulator Screen Shot - iPhone 11 Pro Max - 2020-02-06 at 10 22 51

Closes material-components/material-components-flutter-gallery#133

@guidezpl guidezpl changed the title Implement Crane middle front layer [Gallery] Implement Crane middle front layer Feb 6, 2020
Copy link
Contributor

@perclasson perclasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the widgets are getting pretty big so if they can be broken down into smaller more readable parts that would probably be good but not a blocker.

@guidezpl
Copy link
Member Author

guidezpl commented Feb 6, 2020

LGTM. I think the widgets are getting pretty big so if they can be broken down into smaller more readable parts that would probably be good but not a blocker.

I tried something like that and it felt less readable so I'm going to leave it as is for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix middle tab for Crane study on mobile (5)

2 participants