Infinite list #440
Merged
Infinite list #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can also make this a web demo on the samples page |
|
@johnpryan Sure! That would be great. I'm confused why the Travis CI check hasn't started yet. |
domesticmouse
approved these changes
May 14, 2020
|
btw, @filiph your PR is green on travis |
|
@filiph, I won't have time until tomorrow, but I'd love to give this a review before you land it. |
|
No hurry, I'll wait! |
redbrogdon
approved these changes
May 16, 2020
|
Thanks! I'm glad for every additional pair of eyes. The CI is green, I will squash and merge now. A heads up: one of the "allowed failure" tests failed: https://travis-ci.org/github/flutter/samples/jobs/687657522. It's something with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new sample:
I've been asked about this a lot in the past few months.