Split CI testing based on flutter channels #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le-beta-dev-ci-split
…le-beta-dev-ci-split
|
PTAL @redbrogdon 😄 |
…le-beta-dev-ci-split
…le-beta-dev-ci-split
|
@domesticmouse, this is great. I love that it'll get some of the experimental samples under test with the correct branches. We had two PRs relating to CI setup in flight at the same time, and the other one has been landed. Mind doing a rebase and double-checking that everything is still how you want it? |
redbrogdon
reviewed
Jan 27, 2021
|
|
||
| defaults: | ||
| run: | ||
| shell: bash |
There was a problem hiding this comment.
Interesting. Is it running zsh on macOS?
There was a problem hiding this comment.
Or PowerShell on Windows? 😄
There was a problem hiding this comment.
Powershell on windows by default was the issue.
There was a problem hiding this comment.
Holy cow. I was just kidding around. 😄
There was a problem hiding this comment.
heh, holy cow is usual state of play for DevOps =)
redbrogdon
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out the CI testing between
stable,beta, anddev. This enables us to specify which samples are tested on which specific channel(s).Note, the prior Github Actions CI configuration was masking various breaks, both on untested beta and dev targeted samples, and on the Android compilation CI. I've raised tracking bugs for the various breakages.