Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge add-to-app branch to master without sidenav #3344

Merged
merged 26 commits into from Dec 5, 2019

Conversation

xster
Copy link
Member

@xster xster commented Dec 5, 2019

No description provided.

xster and others added 19 commits November 21, 2019 18:35
* Created a guide for adding a single Flutter screen to an Android app. (#2783)

* Added details about invoking platform channel APIs on the main thread. (#2819)

* Added splash screen guide for Android. (#2823)

* Create guide for adding a FlutterFragment to an existing Android app. (#2798)

* add a deploy target

* Remove non-existent links
@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Dec 5, 2019
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting! LGTM

@sfshaza2
Copy link
Contributor

sfshaza2 commented Dec 5, 2019

* Reduce add-to-app iOS setup image size, other cleanup

* Indent for continuous numbering

* use {% include } and copy directory ASCII art from Android setup page
@legalcodes
Copy link
Contributor

@sfshaza2 I just ran this branch locally, there is no problem (response 200) with /docs/development/ui/assets-and-images

@sfshaza2
Copy link
Contributor

sfshaza2 commented Dec 5, 2019

Yeah, @legalcodes, it looks like they've modified it and now link to a new image that is not at that URL.

@xster
Copy link
Member Author

xster commented Dec 5, 2019

Do you guys know what's up with https://travis-ci.org/flutter/website/jobs/621344022?utm_medium=notification&utm_source=github_status

I could rebase to master again as a way to try again but it would break PRs in progress.

xster and others added 3 commits December 5, 2019 14:49
* Removed markdown linter errors.
* replaced another 'terminal' with 'sh'
* Made the directory listings consistent.
@xster xster merged commit 6b0bbac into master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants