Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boilerplate simplification #5134

Merged
merged 10 commits into from
Mar 29, 2024
Merged

Boilerplate simplification #5134

merged 10 commits into from
Mar 29, 2024

Conversation

eapolinario
Copy link
Contributor

Tracking issue

#5133

Why are the changes needed?

Having a single source of truth for boilerplate is going to streamline contributions and decrease duplication in dependabot alerts.

What changes were proposed in this pull request?

Move boilerplate to the monorepo and use it as the source of truth in each component. This includes removing the original copy of boilerplate from each component directory as well.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. documentation Improvements or additions to documentation housekeeping Issues that help maintain flyte and keep it tech-debt free labels Mar 28, 2024
@eapolinario eapolinario removed the documentation Improvements or additions to documentation label Mar 28, 2024
@eapolinario eapolinario mentioned this pull request Mar 28, 2024
3 tasks
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 59.03%. Comparing base (78a690f) to head (8621850).
Report is 12 commits behind head on master.

Files Patch % Lines
...ytepropeller/pkg/controller/nodes/array/handler.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5134      +/-   ##
==========================================
+ Coverage   59.00%   59.03%   +0.03%     
==========================================
  Files         645      645              
  Lines       55672    55722      +50     
==========================================
+ Hits        32847    32897      +50     
  Misses      20230    20230              
  Partials     2595     2595              
Flag Coverage Δ
unittests 59.03% <66.66%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario mentioned this pull request Mar 28, 2024
3 tasks
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 29, 2024
@eapolinario eapolinario merged commit 61b0b27 into master Mar 29, 2024
48 checks passed
@eapolinario eapolinario deleted the boilerplate-simplification branch March 29, 2024 18:23
@eapolinario eapolinario mentioned this pull request Mar 29, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants