Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate ray pflags #5149

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Regenerate ray pflags #5149

merged 1 commit into from
Mar 29, 2024

Conversation

eapolinario
Copy link
Contributor

Tracking issue

NA

Why are the changes needed?

Ray config pflags were updated in #5134, but that conflicted with #5067.

What changes were proposed in this pull request?

Just regenerate flyteplugins pflags.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.17%. Comparing base (921a536) to head (10b6e88).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5149      +/-   ##
==========================================
- Coverage   59.64%   59.17%   -0.47%     
==========================================
  Files         312      645     +333     
  Lines       26062    55466   +29404     
==========================================
+ Hits        15544    32822   +17278     
- Misses       9275    20055   +10780     
- Partials     1243     2589    +1346     
Flag Coverage Δ
unittests 59.47% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario merged commit a9847ef into master Mar 29, 2024
46 of 48 checks passed
@eapolinario eapolinario deleted the regenerate-ray-flags branch March 29, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant