Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix typo in launch entity rollback #502

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Fix typo in launch entity rollback #502

merged 1 commit into from
Dec 12, 2022

Conversation

katrogan
Copy link
Contributor

Signed-off-by: Katrina Rogan katroganGH@gmail.com

TL;DR

Fixes typo in executions model migration rollback code introducing the launch_entity column. Sidenote: it would be terrific if gorm model fields' respective db names could be referenced programmatically 😅

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Discovered thru manual review

Tracking Issue

flyteorg/flyte#3144

Follow-up issue

NA

Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #502 (0db161b) into master (77157ff) will increase coverage by 1.47%.
The diff coverage is 0.00%.

❗ Current head 0db161b differs from pull request most recent head 3a1f9a2. Consider uploading reports for the commit 3a1f9a2 to get more accurate results

@@            Coverage Diff             @@
##           master     #502      +/-   ##
==========================================
+ Coverage   60.20%   61.67%   +1.47%     
==========================================
  Files         158      158              
  Lines       14074    11585    -2489     
==========================================
- Hits         8473     7145    -1328     
+ Misses       4860     3699    -1161     
  Partials      741      741              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/repositories/config/migrations.go 2.58% <0.00%> (-0.70%) ⬇️
auth/identity_context.go 64.28% <0.00%> (-3.72%) ⬇️
...ync/notifications/implementations/aws_processor.go 65.67% <0.00%> (-3.47%) ⬇️
pkg/rpc/adminservice/util/metrics.go 69.69% <0.00%> (-2.81%) ⬇️
...ync/notifications/implementations/gcp_processor.go 65.85% <0.00%> (-2.15%) ⬇️
auth/authzserver/token.go 58.82% <0.00%> (-2.05%) ⬇️
pkg/manager/impl/executions/queues.go 90.38% <0.00%> (-1.68%) ⬇️
.../notifications/implementations/sendgrid_emailer.go 71.79% <0.00%> (-1.68%) ⬇️
auth/handlers.go 33.05% <0.00%> (-1.57%) ⬇️
auth/authzserver/authorize.go 20.63% <0.00%> (-1.46%) ⬇️
... and 135 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@katrogan katrogan merged commit fce143d into master Dec 12, 2022
@katrogan katrogan deleted the launch-entity-typo branch December 12, 2022 22:24
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>

Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants