Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create non-root user after apt-get #1519

Merged
merged 3 commits into from
Feb 23, 2023
Merged

Create non-root user after apt-get #1519

merged 3 commits into from
Feb 23, 2023

Conversation

eapolinario
Copy link
Collaborator

TL;DR

apt needs to be run as root user

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

@eapolinario
Create non-root user after apt-get
6dd4129 
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario eapolinario changed the title Create non-root user after apt-get [wip] Create non-root user after apt-get Feb 23, 2023
@codecov
Copy link

codecov bot commented Feb 23, 2023 •
edited
Loading

Codecov Report

Merging #1519 (c315230) into master (d682410) will decrease coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1519      +/-   ##
==========================================
- Coverage   69.28%   69.09%   -0.19%     
==========================================
  Files         315      315              
  Lines       28845    28830      -15     
  Branches     2741     2333     -408     
==========================================
- Hits        19986    19921      -65     
- Misses       8341     8385      +44     
- Partials      518      524       +6
Impacted Files Coverage Δ
tests/flytekit/unit/extras/tasks/test_shell.py 74.26% <0.00%> (-25.74%) ⬇️
flytekit/extras/tasks/shell.py 65.14% <0.00%> (-12.58%) ⬇️
flytekit/extras/persistence/http.py 18.36% <0.00%> (-6.13%) ⬇️
tests/flytekit/unit/tools/test_ignore.py 98.62% <0.00%> (-1.38%) ⬇️
flytekit/core/promise.py 51.96% <0.00%> (-0.57%) ⬇️
flytekit/clis/flyte_cli/main.py 44.34% <0.00%> (ø)
flytekit/types/directory/__init__.py 0.00% <0.00%> (ø)
flytekit/types/schema/types.py 38.30% <0.00%> (+0.15%) ⬆️
flytekit/models/security.py 13.15% <0.00%> (+0.33%) ⬆️
flytekit/types/file/file.py 61.11% <0.00%> (+0.42%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

pingsutw
pingsutw previously approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, my bad. I moved it to the above section when creating a pr, I thought it would work.

@pingsutw
Create user after pip install
fc539dd 
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw
Copy link
Member

pingsutw commented Feb 23, 2023 •
edited
Loading

Moved useradd below pip install, and built a new image to test it. pingsutw/flytekit-test:latest

image

@eapolinario eapolinario changed the title [wip] Create non-root user after apt-get Create non-root user after apt-get Feb 23, 2023
@pingsutw pingsutw merged commit 7a77508 into master Feb 23, 2023
wild-endeavor pushed a commit that referenced this pull request Mar 7, 2023
@eapolinario @pingsutw @wild-endeavor
Create non-root user after apt-get (#1519)
f829653 
* Create non-root user after apt-get

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Create user after pip install

Signed-off-by: Kevin Su <pingsutw@apache.org>

---------

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Kevin Su <pingsutw@apache.org>
wild-endeavor pushed a commit that referenced this pull request Mar 7, 2023
@eapolinario @pingsutw @wild-endeavor
Create non-root user after apt-get (#1519)
a09a80b 
* Create non-root user after apt-get

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Create user after pip install

Signed-off-by: Kevin Su <pingsutw@apache.org>

---------

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Kevin Su <pingsutw@apache.org>
eapolinario added a commit that referenced this pull request Mar 8, 2023
@wild-endeavor @eapolinario
@pingsutw @samhita-alla @cosmicBboy
Backport 1.4 onto v1.2 release branch (#1542)
074262b 
* Create non-root user after apt-get (#1519)

* Create non-root user after apt-get

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Create user after pip install

Signed-off-by: Kevin Su <pingsutw@apache.org>

---------

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Kevin Su <pingsutw@apache.org>

* Add root pyflyte reference to docs (#1520)

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* DuckDB plugin (#1419)

* DuckDB integration

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* add sd test and fix import

Signed-off-by: Samhita Alla <samhitaalla@Samhitas-MacBook-Pro.local>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* fix lint error

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* fix lint error

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* list to List

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* lint

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* incorporated suggestions

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* add duckdb to requirements and add gh action to detect doc warnings and errors

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* gh action: python 3.9

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* docs python 3.8 to 3.9

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

---------

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <samhitaalla@Samhitas-MacBook-Pro.local>
Co-authored-by: Kevin Su <pingsutw@apache.org>

* add string as a valid input (#1527)

* add string as a valid input

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* isort

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* tests

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* Lint

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

---------

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Add back attempt to use existing serialization settings when running (#1529)

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

* update configuration docs, fix some docstrings (#1530)

* update configuration docs, fix some docstrings

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* update copy

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* add config init command

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

---------

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* Revert "Make flytekit comply with PEP-561 (#1516)" (#1532)

This reverts commit b3ad158.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

* Failed to initialize FlyteInvalidInputException (#1534)

Signed-off-by: Kevin Su <pingsutw@apache.org>

* cherry pick pin fsspec commit

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

* Set flytekit<1.3.0 in duckdb tests

Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>

* Fix flyteidl==1.2.9 in doc-requirements.txt

Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>

* No duckdb documentation

Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>

* Linting

Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>

---------

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <samhitaalla@Samhitas-MacBook-Pro.local>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Kevin Su <pingsutw@apache.org>
Co-authored-by: Samhita Alla <aallasamhita@gmail.com>
Co-authored-by: Niels Bantilan <niels.bantilan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pingsutw pingsutw pingsutw approved these changes

@wild-endeavor wild-endeavor wild-endeavor approved these changes

@kumare3 kumare3 Awaiting requested review from kumare3 kumare3 is a code owner

@cosmicBboy cosmicBboy Awaiting requested review from cosmicBboy cosmicBboy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eapolinario @pingsutw @wild-endeavor