Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add string as a valid input #1527

Merged
merged 4 commits into from
Mar 1, 2023
Merged

add string as a valid input #1527

merged 4 commits into from
Mar 1, 2023

Conversation

samhita-alla
Copy link
Contributor

TL;DR

This PR supports string as a valid input for DuckDB queries. This is helpful when the list is complex.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #1527 (00e2cf9) into master (d0b72a8) will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1527      +/-   ##
==========================================
+ Coverage   69.09%   69.26%   +0.16%     
==========================================
  Files         315      315              
  Lines       28812    28844      +32     
  Branches     2333     2741     +408     
==========================================
+ Hits        19907    19978      +71     
+ Misses       8383     8349      -34     
+ Partials      522      517       -5     
Impacted Files Coverage Δ
flytekit/interfaces/random.py 20.00% <0.00%> (-5.00%) ⬇️
flytekit/configuration/internal.py 16.21% <0.00%> (-1.97%) ⬇️
flytekit/types/directory/types.py 55.73% <0.00%> (-0.47%) ⬇️
flytekit/types/file/file.py 60.68% <0.00%> (-0.43%) ⬇️
flytekit/clients/helpers.py 5.88% <0.00%> (-0.37%) ⬇️
flytekit/models/security.py 12.82% <0.00%> (-0.34%) ⬇️
flytekit/clis/flyte_cli/main.py 44.34% <0.00%> (-0.29%) ⬇️
flytekit/types/schema/types.py 38.15% <0.00%> (-0.16%) ⬇️
...t/clients/grpc_utils/wrap_exception_interceptor.py 2.70% <0.00%> (-0.08%) ⬇️
flytekit/types/directory/__init__.py 0.00% <0.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario eapolinario merged commit e84b9b0 into master Mar 1, 2023
wild-endeavor pushed a commit that referenced this pull request Mar 7, 2023
* add string as a valid input

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* isort

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* tests

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* Lint

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

---------

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
wild-endeavor pushed a commit that referenced this pull request Mar 7, 2023
* add string as a valid input

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* isort

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* tests

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* Lint

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

---------

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario added a commit that referenced this pull request Mar 8, 2023
* Create non-root user after apt-get (#1519)

* Create non-root user after apt-get

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Create user after pip install

Signed-off-by: Kevin Su <pingsutw@apache.org>

---------

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Kevin Su <pingsutw@apache.org>

* Add root pyflyte reference to docs (#1520)

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* DuckDB plugin (#1419)

* DuckDB integration

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* add sd test and fix import

Signed-off-by: Samhita Alla <samhitaalla@Samhitas-MacBook-Pro.local>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* fix lint error

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* fix lint error

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* list to List

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* lint

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* incorporated suggestions

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* add duckdb to requirements and add gh action to detect doc warnings and errors

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* gh action: python 3.9

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* docs python 3.8 to 3.9

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

---------

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <samhitaalla@Samhitas-MacBook-Pro.local>
Co-authored-by: Kevin Su <pingsutw@apache.org>

* add string as a valid input (#1527)

* add string as a valid input

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* isort

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* tests

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* Lint

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

---------

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Add back attempt to use existing serialization settings when running (#1529)

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

* update configuration docs, fix some docstrings (#1530)

* update configuration docs, fix some docstrings

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* update copy

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* add config init command

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

---------

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* Revert "Make flytekit comply with PEP-561 (#1516)" (#1532)

This reverts commit b3ad158.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

* Failed to initialize FlyteInvalidInputException (#1534)

Signed-off-by: Kevin Su <pingsutw@apache.org>

* cherry pick pin fsspec commit

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

* Set flytekit<1.3.0 in duckdb tests

Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>

* Fix flyteidl==1.2.9 in doc-requirements.txt

Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>

* No duckdb documentation

Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>

* Linting

Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>

---------

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <samhitaalla@Samhitas-MacBook-Pro.local>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Kevin Su <pingsutw@apache.org>
Co-authored-by: Samhita Alla <aallasamhita@gmail.com>
Co-authored-by: Niels Bantilan <niels.bantilan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants