This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Split templating scheme #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## jeev/tasklog-tmpl-vars #373 +/- ##
==========================================================
+ Coverage 62.87% 64.21% +1.34%
==========================================================
Files 153 154 +1
Lines 12893 10570 -2323
==========================================================
- Hits 8107 6788 -1319
+ Misses 4172 3168 -1004
Partials 614 614
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pmahindrakar-oss
approved these changes
Jul 14, 2023
jeevb
added a commit
that referenced
this pull request
Jul 15, 2023
…372) * Refactor task log templates to support extra vars * plumbing for k8s * Cleanup use of providers * cleanup * more cleanups * more cleanups * more cleanups * Plumb through task context for plugins * fix Signed-off-by: Jeev B <jeevb@users.noreply.github.com> * move task execution identifier into Input struct * use pointer * tests Signed-off-by: Jeev B <jeevb@users.noreply.github.com> * fix linting Signed-off-by: Jeev B <jeevb@users.noreply.github.com> * cleanups * fix * revert to using regex replacements for performance * Readd benchmark * Split templating scheme (#373) * Use a split templating scheme * add enum for TemplateScheme * cleanup comment * fix linting issues * add unit tests for templateVarsForScheme * update for consistency --------- Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
…372) * Refactor task log templates to support extra vars * plumbing for k8s * Cleanup use of providers * cleanup * more cleanups * more cleanups * more cleanups * Plumb through task context for plugins * fix Signed-off-by: Jeev B <jeevb@users.noreply.github.com> * move task execution identifier into Input struct * use pointer * tests Signed-off-by: Jeev B <jeevb@users.noreply.github.com> * fix linting Signed-off-by: Jeev B <jeevb@users.noreply.github.com> * cleanups * fix * revert to using regex replacements for performance * Readd benchmark * Split templating scheme (#373) * Use a split templating scheme * add enum for TemplateScheme * cleanup comment * fix linting issues * add unit tests for templateVarsForScheme * update for consistency --------- Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.