Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation + some fixes #40

Merged
merged 7 commits into from Apr 25, 2020
Merged

Documentation + some fixes #40

merged 7 commits into from Apr 25, 2020

Conversation

artemisart
Copy link

Hi,
I though it was too bad that there was no documentation for this package, and that it seriously hurts its discoverability so I started creating one.
To preview it, run make -C docs apidoc html and then open docs/build/html/index.html. The documentation will be uploadable to readthedocs.io.
I also tried to improve the README + some docstrings and converted existing code blocks to doctests, let me know what you think about it 馃檪.

@javadba
Copy link

javadba commented Mar 29, 2020

The only problem here is stupid 79 character limit.

./fn/immutable/heap.py:135:80: E501 line too long (86 > 79 characters)
ERROR: InvocationError for command /home/travis/build/fnpy/fn.py/.tox/codestyle/bin/pycodestyle (exited with code 1)
___________________________________ summary ____________________________________
ERROR: codestyle: commands failed
The command "tox" exited with 1.

I have a PR to fix this on @artemisart fork / doc branch

artemisart#1

@howiezhao howiezhao merged commit d8c21ab into fnpy:master Apr 25, 2020
@howiezhao
Copy link
Member

LGTM! 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants