Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popup): star icons were missing in predefinded html example #187

Merged

Conversation

lubber-de
Copy link
Member

Description

The popup example with predefeined HTML missed the rating star icons

Screenshots

image

Closes

#185

@lubber-de lubber-de added Confirmed Bug Issues which are confirmed to be a bug Fix Pull requests which fix broken examples labels Dec 9, 2019
@lubber-de lubber-de added this to the 2.8.3 milestone Dec 9, 2019
Copy link
Contributor

@exoego exoego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami changed the title fix(popup): star icons were missing in popup example of predefined html fix(popup): star icons were missing in predefinded html example Dec 22, 2019
@y0hami y0hami merged commit 611b7d3 into fomantic:develop Dec 22, 2019
@lubber-de lubber-de deleted the fix/185/missing_stars_in_popup_example branch December 22, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed Bug Issues which are confirmed to be a bug Fix Pull requests which fix broken examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants