Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): floating shadow and radius on direct child menu only #2284

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

grandeljay
Copy link
Contributor

It's just a 1 character change so I'll keep it short:

There's an ugly and probably unwanted shadow and radius on the inner floating dropdown .menu which this fix removes.

https://jsfiddle.net/0cpwnfkz/

image

Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!
LGTM

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS labels Mar 28, 2022
@lubber-de lubber-de added this to the 2.9.0 milestone Mar 28, 2022
@lubber-de lubber-de changed the title Fix floating dropdown shadow and radius fix(dropdown): floating shadow and radius on direct child menu only Mar 28, 2022
@lubber-de lubber-de merged commit 987c646 into fomantic:develop Mar 28, 2022
@lubber-de
Copy link
Member

@all-contributors please add @grandeljay for code

@allcontributors
Copy link
Contributor

@lubber-de

I've put up a pull request to add @grandeljay! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants