Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Header] Attached inverted variant should have same background color as other inverted components #338

Merged
merged 1 commit into from
Jan 2, 2019
Merged

[Header] Attached inverted variant should have same background color as other inverted components #338

merged 1 commit into from
Jan 2, 2019

Conversation

lubber-de
Copy link
Member

Description

This PR sets the default background color for inverted attached header to the same as it already is for inverted attached segment or inverted attached menu

Testcase

http://jsfiddle.net/9hhkqwf8/2/
Remove CSS to see previous behavior.

Closes

Semantic-Org/Semantic-UI#5435

@lubber-de lubber-de added lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews labels Dec 31, 2018
@lubber-de lubber-de added the tag/sui-issue Taken from an existing Issue/PR of SUI label Dec 31, 2018
ColinFrick
ColinFrick approved these changes Dec 31, 2018
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

prudho
prudho approved these changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 25f417e into fomantic:develop Jan 2, 2019
@y0hami y0hami added 🐛 bugfix and removed state/awaiting-reviews Pull requests which are waiting for reviews labels Jan 2, 2019
@lubber-de lubber-de deleted the fix/5435/inverted_attached_header_background branch January 2, 2019 17:26
@lubber-de lubber-de added this to the 2.7.2 milestone Jan 2, 2019
@y0hami y0hami mentioned this pull request Feb 4, 2019
Merged
@exoego exoego added type/bug Any issue which is a bug or PR which fixes a bug and removed 🐛 bugfix labels May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prudho prudho prudho approved these changes

@ColinFrick ColinFrick ColinFrick approved these changes

@y0hami y0hami Awaiting requested review from y0hami

Assignees
No one assigned
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.2
Development

Successfully merging this pull request may close these issues.
5 participants
@lubber-de @ColinFrick @prudho @exoego @y0hami