Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transition] Transitions made of hidden inline style elements were not animated correctly anymore #474

Merged
merged 1 commit into from
Feb 11, 2019

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Feb 11, 2019

Description

This PR fixes a regression since #357. All transitions made out of elements being invisible by an inline style display:none were not working correctly anymore.

Testcase

The subheader of the title should animate by the drop transition

Broken

http://jsfiddle.net/q2u0hjy1

Fixed

http://jsfiddle.net/bc5hgv9j/1/

@lubber-de lubber-de added lang/javascript Anything involving JavaScript state/awaiting-reviews Pull requests which are waiting for reviews 🐛 bugfix labels Feb 11, 2019
@lubber-de lubber-de added this to the 2.7.3 milestone Feb 11, 2019
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 0a05e9f into fomantic:develop Feb 11, 2019
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Feb 11, 2019
@lubber-de
Copy link
Member Author

This also fixes #581

@y0hami y0hami mentioned this pull request Apr 1, 2019
@lubber-de lubber-de deleted the fix/transition_inline_hidden branch April 2, 2019 09:06
@exoego exoego added type/bug Any issue which is a bug or PR which fixes a bug and removed 🐛 bugfix labels May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants