Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Transition] Transitions made of hidden inline style elements were not animated correctly anymore #474

Merged
merged 1 commit into from
Feb 11, 2019
Merged

[Transition] Transitions made of hidden inline style elements were not animated correctly anymore #474

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions src/definitions/modules/transition.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,9 +263,6 @@ $.fn.transition = function() {
$module
.attr('style', overrideStyle)
;
if(style === '') {
$module.removeAttr('style');
}
return true;
},
hidden: function() {
Expand Down Expand Up @@ -314,22 +311,17 @@ $.fn.transition = function() {

set: {
animating: function(animation) {
// override display if necessary so animation appears visibly
if(module.force.visible()) {
var
animationClass,
direction
;
// remove previous callbacks
module.remove.completeCallback();
// remove previous callbacks
module.remove.completeCallback();

// determine exact animation
animation = animation || settings.animation;
animationClass = module.get.animationClass(animation);
// determine exact animation
animation = animation || settings.animation;
var animationClass = module.get.animationClass(animation);

// save animation class in cache to restore class names
module.save.animation(animationClass);
module.save.animation(animationClass);

if(module.force.visible()) {
module.remove.hidden();
module.remove.direction();

Expand Down